kevin/linux
1
Fork 0
Code

pstore/zone: Add a null pointer check to the psz_kmsg_read

Browse Source 
kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.

Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Link: https://lore.kernel.org/r/20240118100206.213928-1-chentao@kylinos.cn
Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Kunwu Chan 2024-01-18 18:02:06 +08:00 committed by Kees Cook
parent a28655c330
commit 98bc7e26e1
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/pstore/zone.c
View File

@ -973,6 +973,8 @@ static ssize_t psz_kmsg_read(struct pstore_zone *zone,
char *buf = kasprintf(GFP_KERNEL, "%s: Total %d times\n", char *buf = kasprintf(GFP_KERNEL, "%s: Total %d times\n",
kmsg_dump_reason_str(record->reason), kmsg_dump_reason_str(record->reason),
record->count); record->count);
if (!buf)
return -ENOMEM;
hlen = strlen(buf); hlen = strlen(buf);
record->buf = krealloc(buf, hlen + size, GFP_KERNEL); record->buf = krealloc(buf, hlen + size, GFP_KERNEL);
if (!record->buf) { if (!record->buf) {