kevin/linux
1
Fork 0
Code

kunit/overflow: Fix UB in overflow_allocation_test

Browse Source 
The 'device_name' array doesn't exist out of the
'overflow_allocation_test' function scope. However, it is being used as
a driver name when calling 'kunit_driver_create' from
'kunit_device_register'. It produces the kernel panic with KASAN
enabled.

Since this variable is used in one place only, remove it and pass the
device name into kunit_device_register directly as an ascii string.

Signed-off-by: Ivan Orlov <ivan.orlov0322@gmail.com>
Reviewed-by: David Gow <davidgow@google.com>
Link: https://lore.kernel.org/r/20240815000431.401869-1-ivan.orlov0322@gmail.com
Signed-off-by: Kees Cook <kees@kernel.org>
This commit is contained in:
Ivan Orlov 2024-08-15 01:04:31 +01:00 committed by Kees Cook
parent f32e90c068
commit 92e9bac181
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/overflow_kunit.c
View File

@ -668,7 +668,6 @@ DEFINE_TEST_ALLOC(devm_kzalloc, devm_kfree, 1, 1, 0);
static void overflow_allocation_test(struct kunit *test) static void overflow_allocation_test(struct kunit *test)
{ {
const char device_name[] = "overflow-test";
struct device *dev; struct device *dev;
int count = 0; int count = 0;
@ -678,7 +677,7 @@ static void overflow_allocation_test(struct kunit *test)
} while (0) } while (0)
/* Create dummy device for devm_kmalloc()-family tests. */ /* Create dummy device for devm_kmalloc()-family tests. */
dev = kunit_device_register(test, device_name); dev = kunit_device_register(test, "overflow-test");
KUNIT_ASSERT_FALSE_MSG(test, IS_ERR(dev), KUNIT_ASSERT_FALSE_MSG(test, IS_ERR(dev),
"Cannot register test device\n"); "Cannot register test device\n");