kevin/linux
1
Fork 0
Code

gpio: sloppy-logic-analyzer: Check for error code from devm_mutex_init() call

Browse Source 
Even if it's not critical, the avoidance of checking the error code
from devm_mutex_init() call today diminishes the point of using devm
variant of it. Tomorrow it may even leak something. Add the missed
check.

Fixes: 7828b7bbbf ("gpio: add sloppy logic analyzer using polling")
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20241030174132.2113286-3-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
This commit is contained in:
Andy Shevchenko 2024-10-30 19:36:52 +02:00 committed by Bartosz Golaszewski
parent a14968aea6
commit 90bad74985
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/gpio/gpio-sloppy-logic-analyzer.c
View File

@ -234,7 +234,9 @@ static int gpio_la_poll_probe(struct platform_device *pdev)
if (!priv)
return -ENOMEM;
devm_mutex_init(dev, &priv->blob_lock);
ret = devm_mutex_init(dev, &priv->blob_lock);
if (ret)
return ret;
fops_buf_size_set(priv, GPIO_LA_DEFAULT_BUF_SIZE);