net: cipso: fix warnings in netlbl_cipsov4_add_std
Syzbot reported warning in netlbl_cipsov4_add(). The
problem was in too big doi_def->map.std->lvl.local_size
passed to kcalloc(). Since this value comes from userpace there is
no need to warn if value is not correct.
The same problem may occur with other kcalloc() calls in
this function, so, I've added __GFP_NOWARN flag to all
kcalloc() calls there.
Reported-and-tested-by: syzbot+cdd51ee2e6b0b2e18c0d@syzkaller.appspotmail.com
Fixes: 96cb8e3313
("[NetLabel]: CIPSOv4 and Unlabeled packet integration")
Acked-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
2f21be447b
commit
8ca34a13f7
@ -187,14 +187,14 @@ static int netlbl_cipsov4_add_std(struct genl_info *info,
|
||||
}
|
||||
doi_def->map.std->lvl.local = kcalloc(doi_def->map.std->lvl.local_size,
|
||||
sizeof(u32),
|
||||
GFP_KERNEL);
|
||||
GFP_KERNEL | __GFP_NOWARN);
|
||||
if (doi_def->map.std->lvl.local == NULL) {
|
||||
ret_val = -ENOMEM;
|
||||
goto add_std_failure;
|
||||
}
|
||||
doi_def->map.std->lvl.cipso = kcalloc(doi_def->map.std->lvl.cipso_size,
|
||||
sizeof(u32),
|
||||
GFP_KERNEL);
|
||||
GFP_KERNEL | __GFP_NOWARN);
|
||||
if (doi_def->map.std->lvl.cipso == NULL) {
|
||||
ret_val = -ENOMEM;
|
||||
goto add_std_failure;
|
||||
@ -263,7 +263,7 @@ static int netlbl_cipsov4_add_std(struct genl_info *info,
|
||||
doi_def->map.std->cat.local = kcalloc(
|
||||
doi_def->map.std->cat.local_size,
|
||||
sizeof(u32),
|
||||
GFP_KERNEL);
|
||||
GFP_KERNEL | __GFP_NOWARN);
|
||||
if (doi_def->map.std->cat.local == NULL) {
|
||||
ret_val = -ENOMEM;
|
||||
goto add_std_failure;
|
||||
@ -271,7 +271,7 @@ static int netlbl_cipsov4_add_std(struct genl_info *info,
|
||||
doi_def->map.std->cat.cipso = kcalloc(
|
||||
doi_def->map.std->cat.cipso_size,
|
||||
sizeof(u32),
|
||||
GFP_KERNEL);
|
||||
GFP_KERNEL | __GFP_NOWARN);
|
||||
if (doi_def->map.std->cat.cipso == NULL) {
|
||||
ret_val = -ENOMEM;
|
||||
goto add_std_failure;
|
||||
|
Loading…
Reference in New Issue
Block a user