kevin/linux
1
Fork 0
Code

mm/kmemleak: use IS_ERR_PCPU() for pointer in the percpu address space

Browse Source 
Use IS_ERR_PCPU() instead of IS_ERR() for pointers in the percpu address
space.  The patch also fixes following sparse warnings:

kmemleak.c:1063:39: warning: cast removes address space '__percpu' of expression
kmemleak.c:1138:37: warning: cast removes address space '__percpu' of expression

Link: https://lkml.kernel.org/r/20240818210235.33481-2-ubizjak@gmail.com
Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Uros Bizjak 2024-08-18 23:01:52 +02:00 committed by Andrew Morton
parent a759e37fb4
commit 8c86859289
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
mm/kmemleak.c
View File

@ -1070,8 +1070,8 @@ void __ref kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,
{ {
pr_debug("%s(0x%px, %zu)\n", __func__, ptr, size); pr_debug("%s(0x%px, %zu)\n", __func__, ptr, size);
if (kmemleak_enabled && ptr && !IS_ERR(ptr)) if (kmemleak_enabled && ptr && !IS_ERR_PCPU(ptr))
create_object_percpu((unsigned long)ptr, size, 1, gfp); create_object_percpu((__force unsigned long)ptr, size, 0, gfp);
} }
EXPORT_SYMBOL_GPL(kmemleak_alloc_percpu); EXPORT_SYMBOL_GPL(kmemleak_alloc_percpu);
@ -1145,8 +1145,8 @@ void __ref kmemleak_free_percpu(const void __percpu *ptr)
{ {
pr_debug("%s(0x%px)\n", __func__, ptr); pr_debug("%s(0x%px)\n", __func__, ptr);
if (kmemleak_free_enabled && ptr && !IS_ERR(ptr)) if (kmemleak_free_enabled && ptr && !IS_ERR_PCPU(ptr))
delete_object_full((unsigned long)ptr, OBJECT_PERCPU); delete_object_full((__force unsigned long)ptr, OBJECT_PERCPU);
} }
EXPORT_SYMBOL_GPL(kmemleak_free_percpu); EXPORT_SYMBOL_GPL(kmemleak_free_percpu);