1

media: bcm2835-unicam: Depend on COMMON_CLK

The bcm2835-unicam driver calls the clk_set_min_rate() function, which
is declared but not implemented on platforms that don't provide
COMMON_CLK. This causes linkage failures with some configurations.

Fix it by depending on COMMON_CLK. This only slightly restricts
compilation testing, but not usage of the driver as all platforms on
which the hardware can be found provide COMMON_CLK.

Fixes: 392cd78d49 ("media: bcm2835-unicam: Add support for CCP2/CSI2 camera interface")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202405112243.2MLRT7li-lkp@intel.com/
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Laurent Pinchart 2024-05-13 01:21:04 +03:00 committed by Hans Verkuil
parent eba63df7eb
commit 8771b7f31b

View File

@ -3,7 +3,7 @@
config VIDEO_BCM2835_UNICAM
tristate "Broadcom BCM283x/BCM271x Unicam video capture driver"
depends on ARCH_BCM2835 || COMPILE_TEST
depends on PM
depends on COMMON_CLK && PM
depends on VIDEO_DEV
select MEDIA_CONTROLLER
select V4L2_FWNODE