kevin/linux
1
Fork 0
Code

spi: spi-cadence-quadspi: Fix missing unwind goto warnings

Browse Source 
The following smatch warnings [0] were recently introduced:

drivers/spi/spi-cadence-quadspi.c:1882 cqspi_probe() warn: missing
unwind goto?

Fix these warnings by releasing dma channel and adding a goto fail probe.

[0] https://lore.kernel.org/all/5e21c351-cd08-443e-8509-aecf242a4da9@kadam.mountain/

Fixes: 0578a6dbfe ("spi: spi-cadence-quadspi: add runtime pm support")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202309140543.03dMbMM5-lkp@intel.com/
Signed-off-by: Dhruva Gole <d-gole@ti.com>
Link: https://lore.kernel.org/r/20230919074658.41666-1-d-gole@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Dhruva Gole 2023-09-19 13:16:59 +05:30 committed by Mark Brown
parent 2d9f487798
commit 86401132d7
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/spi/spi-cadence-quadspi.c
View File

@ -1878,8 +1878,11 @@ static int cqspi_probe(struct platform_device *pdev)
}
ret = devm_pm_runtime_enable(dev);
if (ret)
return ret;
if (ret) {
if (cqspi->rx_chan)
dma_release_channel(cqspi->rx_chan);
goto probe_setup_failed;
}
pm_runtime_set_autosuspend_delay(dev, CQSPI_AUTOSUSPEND_TIMEOUT);
pm_runtime_use_autosuspend(dev);