kevin/linux
1
Fork 0
Code

ALSA: hda: cs35l41: Remove redundant call to hda_cs_dsp_control_remove()

Browse Source 
The driver doesn't create any ALSA controls for firmware controls, so it
shouldn't be calling hda_cs_dsp_control_remove().

commit 312c04cee4 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for
firmware coefficients") removed the call to hda_cs_dsp_add_controls() but
didn't remove the call for destroying those controls.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 312c04cee4 ("ALSA: hda: cs35l41: Stop creating ALSA Controls for firmware coefficients")
Link: https://patch.msgid.link/20240813113209.648-1-rf@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Richard Fitzgerald 2024-08-13 12:32:09 +01:00 committed by Takashi Iwai
parent 12d82c7b0a
commit 8475a1d9bb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/pci/hda/cs35l41_hda.c
View File

@ -134,7 +134,7 @@ static const struct reg_sequence cs35l41_hda_mute[] = {
}; };
static const struct cs_dsp_client_ops client_ops = { static const struct cs_dsp_client_ops client_ops = {
.control_remove = hda_cs_dsp_control_remove, /* cs_dsp requires the client to provide this even if it is empty */
}; };
static int cs35l41_request_tuning_param_file(struct cs35l41_hda *cs35l41, char *tuning_filename, static int cs35l41_request_tuning_param_file(struct cs35l41_hda *cs35l41, char *tuning_filename,