kevin/linux
1
Fork 0
Code

spmi: pmic-arb: Fix some compile warnings about members not being described

Browse Source 
Fix the following compile warnings:

 warning: Function parameter or struct member 'core' not described in 'spmi_pmic_arb'
 warning: Function parameter or struct member 'core_size' not described in 'spmi_pmic_arb'
 warning: Function parameter or struct member 'mapping_table_valid' not described in 'spmi_pmic_arb'
 warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_read_data'
 warning: Function parameter or struct member 'pmic_arb' not described in 'pmic_arb_write_data'

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20240417-spmi-multi-master-support-v10-3-5bc6d322e266@linaro.org
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20240507210809.3479953-9-sboyd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Abel Vesa 2024-05-07 14:07:45 -07:00 committed by Greg Kroah-Hartman
parent 345fbbca3f
commit 83bfd7a81f
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/spmi/spmi-pmic-arb.c
View File

@ -132,6 +132,8 @@ struct apid_data {
* @wr_base: on v1 "core", on v2 "chnls" register base off DT. * @wr_base: on v1 "core", on v2 "chnls" register base off DT.
* @intr: address of the SPMI interrupt control registers. * @intr: address of the SPMI interrupt control registers.
* @cnfg: address of the PMIC Arbiter configuration registers. * @cnfg: address of the PMIC Arbiter configuration registers.
* @core: core register base for v2 and above only (see above)
* @core_size: core register base size
* @lock: lock to synchronize accesses. * @lock: lock to synchronize accesses.
* @channel: execution environment channel to use for accesses. * @channel: execution environment channel to use for accesses.
* @irq: PMIC ARB interrupt. * @irq: PMIC ARB interrupt.
@ -144,6 +146,7 @@ struct apid_data {
* @apid_count: on v5 and v7: number of APIDs associated with the * @apid_count: on v5 and v7: number of APIDs associated with the
* particular SPMI bus instance * particular SPMI bus instance
* @mapping_table: in-memory copy of PPID -> APID mapping table. * @mapping_table: in-memory copy of PPID -> APID mapping table.
* @mapping_table_valid:bitmap containing valid-only periphs
* @domain: irq domain object for PMIC IRQ domain * @domain: irq domain object for PMIC IRQ domain
* @spmic: SPMI controller object * @spmic: SPMI controller object
* @ver_ops: version dependent operations. * @ver_ops: version dependent operations.
@ -232,6 +235,7 @@ static inline void pmic_arb_set_rd_cmd(struct spmi_pmic_arb *pmic_arb,
/** /**
* pmic_arb_read_data: reads pmic-arb's register and copy 1..4 bytes to buf * pmic_arb_read_data: reads pmic-arb's register and copy 1..4 bytes to buf
* @pmic_arb: the SPMI PMIC arbiter
* @bc: byte count -1. range: 0..3 * @bc: byte count -1. range: 0..3
* @reg: register's address * @reg: register's address
* @buf: output parameter, length must be bc + 1 * @buf: output parameter, length must be bc + 1
@ -246,6 +250,7 @@ pmic_arb_read_data(struct spmi_pmic_arb *pmic_arb, u8 *buf, u32 reg, u8 bc)
/** /**
* pmic_arb_write_data: write 1..4 bytes from buf to pmic-arb's register * pmic_arb_write_data: write 1..4 bytes from buf to pmic-arb's register
* @pmic_arb: the SPMI PMIC arbiter
* @bc: byte-count -1. range: 0..3. * @bc: byte-count -1. range: 0..3.
* @reg: register's address. * @reg: register's address.
* @buf: buffer to write. length must be bc + 1. * @buf: buffer to write. length must be bc + 1.