kevin/linux
1
Fork 0
Code

pinctrl: freescale: mxs: Fix refcount of child

Browse Source 
of_get_next_child() will increase refcount of the returned node, need
use of_node_put() on it when done.

Per current implementation, 'child' will be override by
for_each_child_of_node(np, child), so use of_get_child_count to avoid
refcount leakage.

Fixes: 17723111e6 ("pinctrl: add pinctrl-mxs support")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/20240504-pinctrl-cleanup-v2-18-26c5f2dc1181@nxp.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Peng Fan 2024-05-04 21:20:16 +08:00 committed by Linus Walleij
parent d7f5120a94
commit 7f500f2011
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/pinctrl/freescale/pinctrl-mxs.c
View File

@ -413,8 +413,8 @@ static int mxs_pinctrl_probe_dt(struct platform_device *pdev,
int ret;
u32 val;
child = of_get_next_child(np, NULL);
if (!child) {
val = of_get_child_count(np);
if (val == 0) {
dev_err(&pdev->dev, "no group is defined\n");
return -ENOENT;
}