kevin/linux
1
Fork 0
Code

spi: armada-3700: use 'time_left' variable with wait_for_completion_timeout()

Browse Source 
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

	timeout = wait_for_completion_timeout(...)
	if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Fix to the proper variable type 'unsigned long' while here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20240430114142.28551-2-wsa+renesas@sang-engineering.com
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Wolfram Sang 2024-04-30 13:41:33 +02:00 committed by Mark Brown
parent 47766799f5
commit 7dbbbb1206
No known key found for this signature in database
GPG Key ID: 24D68B725D5487D0
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/spi/spi-armada-3700.c
View File

@ -339,7 +339,7 @@ static irqreturn_t a3700_spi_interrupt(int irq, void *dev_id)
static bool a3700_spi_wait_completion(struct spi_device *spi) static bool a3700_spi_wait_completion(struct spi_device *spi)
{ {
struct a3700_spi *a3700_spi; struct a3700_spi *a3700_spi;
unsigned int timeout; unsigned long time_left;
unsigned int ctrl_reg; unsigned int ctrl_reg;
unsigned long timeout_jiffies; unsigned long timeout_jiffies;
@ -361,12 +361,12 @@ static bool a3700_spi_wait_completion(struct spi_device *spi)
a3700_spi->wait_mask); a3700_spi->wait_mask);
timeout_jiffies = msecs_to_jiffies(A3700_SPI_TIMEOUT); timeout_jiffies = msecs_to_jiffies(A3700_SPI_TIMEOUT);
timeout = wait_for_completion_timeout(&a3700_spi->done, time_left = wait_for_completion_timeout(&a3700_spi->done,
timeout_jiffies); timeout_jiffies);
a3700_spi->wait_mask = 0; a3700_spi->wait_mask = 0;
if (timeout) if (time_left)
return true; return true;
/* there might be the case that right after we checked the /* there might be the case that right after we checked the