kevin/linux
1
Fork 0
Code

Input: ads7846 - use spi_device_id table

Browse Source 
As the driver supports more devices over time the single MODULE_ALIAS
is complete and raises several warnings:
SPI driver ads7846 has no spi_device_id for ti,tsc2046
SPI driver ads7846 has no spi_device_id for ti,ads7843
SPI driver ads7846 has no spi_device_id for ti,ads7845
SPI driver ads7846 has no spi_device_id for ti,ads7873

Fix this by adding a spi_device_id table and removing the manual
MODULE_ALIAS.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20240619122703.2081476-1-alexander.stein@ew.tq-group.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Alexander Stein 2024-06-19 14:27:02 +02:00 committed by Dmitry Torokhov
parent cee77149eb
commit 7c7b1be19b
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/input/touchscreen/ads7846.c
View File

@ -1111,6 +1111,16 @@ static const struct of_device_id ads7846_dt_ids[] = {
}; };
MODULE_DEVICE_TABLE(of, ads7846_dt_ids); MODULE_DEVICE_TABLE(of, ads7846_dt_ids);
static const struct spi_device_id ads7846_spi_ids[] = {
{ "tsc2046", 7846 },
{ "ads7843", 7843 },
{ "ads7845", 7845 },
{ "ads7846", 7846 },
{ "ads7873", 7873 },
{ },
};
MODULE_DEVICE_TABLE(spi, ads7846_spi_ids);
static const struct ads7846_platform_data *ads7846_get_props(struct device *dev) static const struct ads7846_platform_data *ads7846_get_props(struct device *dev)
{ {
struct ads7846_platform_data *pdata; struct ads7846_platform_data *pdata;
@ -1386,10 +1396,10 @@ static struct spi_driver ads7846_driver = {
}, },
.probe = ads7846_probe, .probe = ads7846_probe,
.remove = ads7846_remove, .remove = ads7846_remove,
.id_table = ads7846_spi_ids,
}; };
module_spi_driver(ads7846_driver); module_spi_driver(ads7846_driver);
MODULE_DESCRIPTION("ADS7846 TouchScreen Driver"); MODULE_DESCRIPTION("ADS7846 TouchScreen Driver");
MODULE_LICENSE("GPL"); MODULE_LICENSE("GPL");
MODULE_ALIAS("spi:ads7846");