1

perf rwsem: Add debug mode that uses a mutex

Mutex error check will capture trying to take the lock recursively and
other problems that rwlock won't. At the expense of concurrency, adda
debug mode that uses a mutex in place of a rwsem.

Signed-off-by: Ian Rogers <irogers@google.com>
Cc: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Sandipan Das <sandipan.das@amd.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: German Gomez <german.gomez@arm.com>
Cc: James Clark <james.clark@arm.com>
Cc: Nick Terrell <terrelln@fb.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Changbin Du <changbin.du@huawei.com>
Cc: liuwenyu <liuwenyu7@huawei.com>
Cc: Yang Jihong <yangjihong1@huawei.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Song Liu <song@kernel.org>
Cc: Leo Yan <leo.yan@linaro.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Yanteng Si <siyanteng@loongson.cn>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Link: https://lore.kernel.org/r/20231024222353.3024098-2-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
This commit is contained in:
Ian Rogers 2023-10-24 15:23:04 -07:00 committed by Namhyung Kim
parent b27778ed5d
commit 7a8f349e9d
2 changed files with 45 additions and 0 deletions

View File

@ -2,32 +2,66 @@
#include "util.h"
#include "rwsem.h"
#if RWS_ERRORCHECK
#include "mutex.h"
#endif
int init_rwsem(struct rw_semaphore *sem)
{
#if RWS_ERRORCHECK
mutex_init(&sem->mtx);
return 0;
#else
return pthread_rwlock_init(&sem->lock, NULL);
#endif
}
int exit_rwsem(struct rw_semaphore *sem)
{
#if RWS_ERRORCHECK
mutex_destroy(&sem->mtx);
return 0;
#else
return pthread_rwlock_destroy(&sem->lock);
#endif
}
int down_read(struct rw_semaphore *sem)
{
#if RWS_ERRORCHECK
mutex_lock(&sem->mtx);
return 0;
#else
return perf_singlethreaded ? 0 : pthread_rwlock_rdlock(&sem->lock);
#endif
}
int up_read(struct rw_semaphore *sem)
{
#if RWS_ERRORCHECK
mutex_unlock(&sem->mtx);
return 0;
#else
return perf_singlethreaded ? 0 : pthread_rwlock_unlock(&sem->lock);
#endif
}
int down_write(struct rw_semaphore *sem)
{
#if RWS_ERRORCHECK
mutex_lock(&sem->mtx);
return 0;
#else
return perf_singlethreaded ? 0 : pthread_rwlock_wrlock(&sem->lock);
#endif
}
int up_write(struct rw_semaphore *sem)
{
#if RWS_ERRORCHECK
mutex_unlock(&sem->mtx);
return 0;
#else
return perf_singlethreaded ? 0 : pthread_rwlock_unlock(&sem->lock);
#endif
}

View File

@ -2,9 +2,20 @@
#define _PERF_RWSEM_H
#include <pthread.h>
#include "mutex.h"
/*
* Mutexes have additional error checking. Enable to use a mutex rather than a
* rwlock for debugging.
*/
#define RWS_ERRORCHECK 0
struct rw_semaphore {
#if RWS_ERRORCHECK
struct mutex mtx;
#else
pthread_rwlock_t lock;
#endif
};
int init_rwsem(struct rw_semaphore *sem);