kevin/linux
1
Fork 0
Code

mm/damon/sysfs-schemes: use damos_commit_quota_goals()

Browse Source 
DAMON_SYSFS manually manipulates the DAMOS quota structs for online quotal
goals parameter update.  Since the struct contains not only input
parameters but also internal status and operation results, it is not that
simple.  Now DAMON core layer provides a function for the usage, namely
damon_commit_quota_goals().  Replace the manual manipulation logic with
the function.  The core layer function could have its own bugs, but this
change removes a source of bugs.

Link: https://lkml.kernel.org/r/20240618181809.82078-5-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
SeongJae Park 2024-06-18 11:18:01 -07:00 committed by Andrew Morton
parent 83dc7bbaec
commit 77ed1eb642
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
mm/damon/sysfs-schemes.c
View File

@ -1983,10 +1983,13 @@ int damos_sysfs_set_quota_scores(struct damon_sysfs_schemes *sysfs_schemes,
struct damon_ctx *ctx)
{
struct damos *scheme;
struct damos_quota quota = {};
int i = 0;
INIT_LIST_HEAD(&quota.goals);
damon_for_each_scheme(scheme, ctx) {
struct damon_sysfs_scheme *sysfs_scheme;
struct damos_quota_goal *g, *g_next;
int err;
/* user could have removed the scheme sysfs dir */
@ -1995,9 +1998,16 @@ int damos_sysfs_set_quota_scores(struct damon_sysfs_schemes *sysfs_schemes,
sysfs_scheme = sysfs_schemes->schemes_arr[i];
err = damos_sysfs_set_quota_score(sysfs_scheme->quotas->goals,
&scheme->quota);
&quota);
if (err) {
damos_for_each_quota_goal_safe(g, g_next, &quota)
damos_destroy_quota_goal(g);
return err;
}
err = damos_commit_quota_goals(&scheme->quota, &quota);
damos_for_each_quota_goal_safe(g, g_next, &quota)
damos_destroy_quota_goal(g);
if (err)
/* kdamond will clean up schemes and terminated */
return err;
i++;
}