kevin/linux
1
Fork 0
Code

pwm: lp3943: Use of_property_count_u32_elems() to get property length

Browse Source 
Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731201407.1838385-8-robh@kernel.org
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
This commit is contained in:
Rob Herring (Arm) 2024-07-31 14:14:03 -06:00 committed by Uwe Kleine-König
parent f9ecc2febf
commit 75f0cb339b
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/pwm/pwm-lp3943.c
View File

@ -218,7 +218,7 @@ static int lp3943_pwm_parse_dt(struct device *dev,
struct lp3943_platform_data *pdata; struct lp3943_platform_data *pdata;
struct lp3943_pwm_map *pwm_map; struct lp3943_pwm_map *pwm_map;
enum lp3943_pwm_output *output; enum lp3943_pwm_output *output;
int i, err, proplen, count = 0; int i, err, count = 0;
u32 num_outputs; u32 num_outputs;
if (!node) if (!node)
@ -234,11 +234,8 @@ static int lp3943_pwm_parse_dt(struct device *dev,
*/ */
for (i = 0; i < LP3943_NUM_PWMS; i++) { for (i = 0; i < LP3943_NUM_PWMS; i++) {
if (!of_get_property(node, name[i], &proplen)) num_outputs = of_property_count_u32_elems(node, name[i]);
continue; if (num_outputs <= 0)
num_outputs = proplen / sizeof(u32);
if (num_outputs == 0)
continue; continue;
output = devm_kcalloc(dev, num_outputs, sizeof(*output), output = devm_kcalloc(dev, num_outputs, sizeof(*output),