kevin/linux
1
Fork 0
Code

m68k: apollo: Replace set but not used variable by READ_ONCE()

Browse Source 
When building with W=1:

    arch/m68k/apollo/config.c: In function ‘dn_timer_int’:
    arch/m68k/apollo/config.c:171:32: warning: variable ‘x’ set but not used [-Wunused-but-set-variable]
      149 |         volatile unsigned char x;
	  |                                ^

Fix this by using READ_ONCE(), and removing the variable.
As READ_ONCE() casts to volatile internally, remove the existing cast.
Deduplicate the remaining casts by introducing an intermediary.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/d0299797d6bf747eca2da998c6c6256485a9f52e.1694613528.git.geert@linux-m68k.org
This commit is contained in:
Geert Uytterhoeven 2023-09-13 16:08:15 +02:00
parent 55775fe94d
commit 7509c04afe
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
arch/m68k/apollo/config.c
View File

@ -146,13 +146,13 @@ void __init config_apollo(void)
irqreturn_t dn_timer_int(int irq, void *dev_id) irqreturn_t dn_timer_int(int irq, void *dev_id)
{ {
volatile unsigned char x; unsigned char *at = (unsigned char *)apollo_timer;
legacy_timer_tick(1); legacy_timer_tick(1);
timer_heartbeat(); timer_heartbeat();
x = *(volatile unsigned char *)(apollo_timer + 3); READ_ONCE(*(at + 3));
x = *(volatile unsigned char *)(apollo_timer + 5); READ_ONCE(*(at + 5));
return IRQ_HANDLED; return IRQ_HANDLED;
} }