kevin/linux
1
Fork 0
Code

wifi: rsi: sdio: simplify module initialization

Browse Source 
This driver's initialization functions do not perform any custom code,
except printing messages.  Printing messages on modules
loading/unloading is discouraged because it pollutes the dmesg
regardless whether user actually has this device.  Core kernel code
already gives tools to investigate whether module was loaded or not.

Drop the printing messages which allows to replace open-coded
module_sdio_driver().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://msgid.link/20240329171019.63836-3-krzysztof.kozlowski@linaro.org
This commit is contained in:
Krzysztof Kozlowski 2024-03-29 18:10:16 +01:00 committed by Kalle Valo
parent 57a03d83f2
commit 73ec84df34
1 changed files with 1 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
drivers/net/wireless/rsi/rsi_91x_sdio.c
View File

@ -1519,36 +1519,7 @@ static struct sdio_driver rsi_driver = {
} }
#endif #endif
}; };
module_sdio_driver(rsi_driver);
/**
* rsi_module_init() - This function registers the sdio module.
* @void: Void.
*
* Return: 0 on success.
*/
static int rsi_module_init(void)
{
int ret;
ret = sdio_register_driver(&rsi_driver);
rsi_dbg(INIT_ZONE, "%s: Registering driver\n", __func__);
return ret;
}
/**
* rsi_module_exit() - This function unregisters the sdio module.
* @void: Void.
*
* Return: None.
*/
static void rsi_module_exit(void)
{
sdio_unregister_driver(&rsi_driver);
rsi_dbg(INFO_ZONE, "%s: Unregistering driver\n", __func__);
}
module_init(rsi_module_init);
module_exit(rsi_module_exit);
MODULE_AUTHOR("Redpine Signals Inc"); MODULE_AUTHOR("Redpine Signals Inc");
MODULE_DESCRIPTION("Common SDIO layer for RSI drivers"); MODULE_DESCRIPTION("Common SDIO layer for RSI drivers");