kevin/linux
1
Fork 0
Code

iommu/vt-d: Fix incorrect pci_for_each_dma_alias() for non-PCI devices

Browse Source 
Previously, the domain_context_clear() function incorrectly called
pci_for_each_dma_alias() to set up context entries for non-PCI devices.
This could lead to kernel hangs or other unexpected behavior.

Add a check to only call pci_for_each_dma_alias() for PCI devices. For
non-PCI devices, domain_context_clear_one() is called directly.

Reported-by: Todd Brandt <todd.e.brandt@intel.com>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219363
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219349
Fixes: 9a16ab9d64 ("iommu/vt-d: Make context clearing consistent with context mapping")
Cc: stable@vger.kernel.org
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Link: https://lore.kernel.org/r/20241014013744.102197-2-baolu.lu@linux.intel.com
Signed-off-by: Joerg Roedel <jroedel@suse.de>
This commit is contained in:
Lu Baolu 2024-10-14 09:37:44 +08:00 committed by Joerg Roedel
parent 8e8a69bc77
commit 6e02a277f1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/iommu/intel/iommu.c
View File

@ -3340,8 +3340,10 @@ static int domain_context_clear_one_cb(struct pci_dev *pdev, u16 alias, void *op
*/ */
static void domain_context_clear(struct device_domain_info *info) static void domain_context_clear(struct device_domain_info *info)
{ {
if (!dev_is_pci(info->dev)) if (!dev_is_pci(info->dev)) {
domain_context_clear_one(info, info->bus, info->devfn); domain_context_clear_one(info, info->bus, info->devfn);
return;
}
pci_for_each_dma_alias(to_pci_dev(info->dev), pci_for_each_dma_alias(to_pci_dev(info->dev),
&domain_context_clear_one_cb, info); &domain_context_clear_one_cb, info);