kevin/linux
1
Fork 0
Code

selinux: add the processing of the failure of avc_add_xperms_decision()

Browse Source 
When avc_add_xperms_decision() fails, the information recorded by the new
avc node is incomplete. In this case, the new avc node should be released
instead of replacing the old avc node.

Cc: stable@vger.kernel.org
Fixes: fa1aa143ac ("selinux: extended permissions for ioctls")
Suggested-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
This commit is contained in:
Zhen Lei 2024-08-07 17:00:56 +08:00 committed by Paul Moore
parent 379d9af3f3
commit 6dd1e4c045
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
security/selinux/avc.c
View File

@ -907,7 +907,11 @@ static int avc_update_node(u32 event, u32 perms, u8 driver, u8 xperm, u32 ssid,
node->ae.avd.auditdeny &= ~perms; node->ae.avd.auditdeny &= ~perms;
break; break;
case AVC_CALLBACK_ADD_XPERMS: case AVC_CALLBACK_ADD_XPERMS:
avc_add_xperms_decision(node, xpd); rc = avc_add_xperms_decision(node, xpd);
if (rc) {
avc_node_kill(node);
goto out_unlock;
}
break; break;
} }
avc_node_replace(node, orig); avc_node_replace(node, orig);