kevin/linux
1
Fork 0
Code

hwmon: (max1668) Use BIT macro

Browse Source 
Use bit macro to make the code easier to understand and reduce duplication.

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Guenter Roeck 2024-07-15 07:22:44 -07:00
parent 74b6451beb
commit 696dbe45fb
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/hwmon/max1668.c
View File

@ -6,6 +6,7 @@
* some credit to Christoph Scheurer, but largely a rewrite * some credit to Christoph Scheurer, but largely a rewrite
*/ */
#include <linux/bits.h>
#include <linux/err.h> #include <linux/err.h>
#include <linux/hwmon.h> #include <linux/hwmon.h>
#include <linux/hwmon-sysfs.h> #include <linux/hwmon-sysfs.h>
@ -172,7 +173,7 @@ static ssize_t show_alarm(struct device *dev, struct device_attribute *attr,
if (IS_ERR(data)) if (IS_ERR(data))
return PTR_ERR(data); return PTR_ERR(data);
return sprintf(buf, "%u\n", (data->alarms >> index) & 0x1); return sprintf(buf, "%u\n", !!(data->alarms & BIT(index)));
} }
static ssize_t show_fault(struct device *dev, static ssize_t show_fault(struct device *dev,
@ -185,7 +186,7 @@ static ssize_t show_fault(struct device *dev,
return PTR_ERR(data); return PTR_ERR(data);
return sprintf(buf, "%u\n", return sprintf(buf, "%u\n",
(data->alarms & (1 << 12)) && data->temp[index] == 127); (data->alarms & BIT(12)) && data->temp[index] == 127);
} }
static ssize_t set_temp_max(struct device *dev, static ssize_t set_temp_max(struct device *dev,