kevin/linux
1
Fork 0
Code

dmaengine: dw: platform: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/r/20230919133207.1400430-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-09-19 15:31:19 +02:00 committed by Vinod Koul
parent c689a2fd2a
commit 67572bfe2e
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/dw/platform.c
View File

@ -93,7 +93,7 @@ err_dw_dma_probe:
return err; return err;
} }
static int dw_remove(struct platform_device *pdev) static void dw_remove(struct platform_device *pdev)
{ {
struct dw_dma_chip_pdata *data = platform_get_drvdata(pdev); struct dw_dma_chip_pdata *data = platform_get_drvdata(pdev);
struct dw_dma_chip *chip = data->chip; struct dw_dma_chip *chip = data->chip;
@ -109,8 +109,6 @@ static int dw_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
clk_disable_unprepare(chip->clk); clk_disable_unprepare(chip->clk);
return 0;
} }
static void dw_shutdown(struct platform_device *pdev) static void dw_shutdown(struct platform_device *pdev)
@ -193,7 +191,7 @@ static const struct dev_pm_ops dw_dev_pm_ops = {
static struct platform_driver dw_driver = { static struct platform_driver dw_driver = {
.probe = dw_probe, .probe = dw_probe,
.remove = dw_remove, .remove_new = dw_remove,
.shutdown = dw_shutdown, .shutdown = dw_shutdown,
.driver = { .driver = {
.name = DRV_NAME, .name = DRV_NAME,