kevin/linux
1
Fork 0
Code

hwmon: (ibmpowernv) Replace deprecated strncpy() with memcpy()

Browse Source 
`strncpy` is deprecated for use on NUL-terminated destination strings [1].

A suitable replacement is `memcpy` as we've already precisely calculated
the number of bytes to copy while `buf` has been explicitly
zero-initialized:
| 	char buf[8] = { 0 };

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1]
Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Justin Stitt <justinstitt@google.com>
Tested-by: Michael Ellerman <mpe@ellerman.id.au>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20230919-strncpy-drivers-hwmon-ibmpowernv-c-v2-1-37d3e64172bc@google.com
Signed-off-by: Kees Cook <keescook@chromium.org>
This commit is contained in:
Justin Stitt 2023-09-19 05:22:51 +00:00 committed by Kees Cook
parent abe6db6c43
commit 66f8a4a0cc
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/hwmon/ibmpowernv.c
View File

@ -234,7 +234,7 @@ static int get_sensor_index_attr(const char *name, u32 *index, char *attr)
if (copy_len >= sizeof(buf)) if (copy_len >= sizeof(buf))
return -EINVAL; return -EINVAL;
strncpy(buf, hash_pos + 1, copy_len); memcpy(buf, hash_pos + 1, copy_len);
err = kstrtou32(buf, 10, index); err = kstrtou32(buf, 10, index);
if (err) if (err)