kevin/linux
1
Fork 0
Code

pinctrl: apple: check devm_kasprintf() returned value

Browse Source 
devm_kasprintf() can return a NULL pointer on failure but this returned
value is not checked. Fix this lack and check the returned value.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: a0f160ffcb ("pinctrl: add pinctrl/GPIO driver for Apple SoCs")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/20240905020917.356534-1-make24@iscas.ac.cn
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
This commit is contained in:
Ma Ke 2024-09-05 10:09:17 +08:00 committed by Linus Walleij
parent 9852d85ec9
commit 665a58fe66
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/pinctrl/pinctrl-apple-gpio.c
View File

@ -474,6 +474,9 @@ static int apple_gpio_pinctrl_probe(struct platform_device *pdev)
for (i = 0; i < npins; i++) { for (i = 0; i < npins; i++) {
pins[i].number = i; pins[i].number = i;
pins[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "PIN%u", i); pins[i].name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "PIN%u", i);
if (!pins[i].name)
return -ENOMEM;
pins[i].drv_data = pctl; pins[i].drv_data = pctl;
pin_names[i] = pins[i].name; pin_names[i] = pins[i].name;
pin_nums[i] = i; pin_nums[i] = i;