kevin/linux
1
Fork 0
Code

net: openvswitch: Release reference to netdev

Browse Source 
dev_get_by_name will provide a reference on the netdev. So ensure that
the reference of netdev is released after completed.

Fixes: 2540088b83 ("net: openvswitch: Check vport netdev name")
Signed-off-by: Jun Gu <jun.gu@easystack.cn>
Reviewed-by: Aaron Conole <aconole@redhat.com>
Link: https://lore.kernel.org/r/20240423073751.52706-1-jun.gu@easystack.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Jun Gu 2024-04-23 15:37:51 +08:00 committed by Jakub Kicinski
parent 9dd15d5088
commit 66270920f9
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
net/openvswitch/vport-netdev.c
View File

@ -78,12 +78,16 @@ struct vport *ovs_netdev_link(struct vport *vport, const char *name)
int err; int err;
vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name); vport->dev = dev_get_by_name(ovs_dp_get_net(vport->dp), name);
if (!vport->dev) {
err = -ENODEV;
goto error_free_vport;
}
/* Ensure that the device exists and that the provided /* Ensure that the device exists and that the provided
* name is not one of its aliases. * name is not one of its aliases.
*/ */
if (!vport->dev || strcmp(name, ovs_vport_name(vport))) { if (strcmp(name, ovs_vport_name(vport))) {
err = -ENODEV; err = -ENODEV;
goto error_free_vport; goto error_put;
} }
netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL); netdev_tracker_alloc(vport->dev, &vport->dev_tracker, GFP_KERNEL);
if (vport->dev->flags & IFF_LOOPBACK || if (vport->dev->flags & IFF_LOOPBACK ||