mmc: owl: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Cc: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Yangtao Li <frank.li@vivo.com> Link: https://lore.kernel.org/r/20230727070051.17778-42-frank.li@vivo.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
parent
3a1d0a8d1c
commit
65c86da4b1
@ -668,7 +668,7 @@ err_free_host:
|
||||
return ret;
|
||||
}
|
||||
|
||||
static int owl_mmc_remove(struct platform_device *pdev)
|
||||
static void owl_mmc_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct mmc_host *mmc = platform_get_drvdata(pdev);
|
||||
struct owl_mmc_host *owl_host = mmc_priv(mmc);
|
||||
@ -677,8 +677,6 @@ static int owl_mmc_remove(struct platform_device *pdev)
|
||||
disable_irq(owl_host->irq);
|
||||
dma_release_channel(owl_host->dma);
|
||||
mmc_free_host(mmc);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static const struct of_device_id owl_mmc_of_match[] = {
|
||||
@ -694,7 +692,7 @@ static struct platform_driver owl_mmc_driver = {
|
||||
.of_match_table = owl_mmc_of_match,
|
||||
},
|
||||
.probe = owl_mmc_probe,
|
||||
.remove = owl_mmc_remove,
|
||||
.remove_new = owl_mmc_remove,
|
||||
};
|
||||
module_platform_driver(owl_mmc_driver);
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user