ptp: fc3: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Simon Horman <horms@kernel.org> Link: https://lore.kernel.org/r/20240304091325.717546-2-u.kleine-koenig@pengutronix.de Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
parent
73a42f4174
commit
60d06425e0
@ -996,13 +996,11 @@ static int idtfc3_probe(struct platform_device *pdev)
|
||||
return 0;
|
||||
}
|
||||
|
||||
static int idtfc3_remove(struct platform_device *pdev)
|
||||
static void idtfc3_remove(struct platform_device *pdev)
|
||||
{
|
||||
struct idtfc3 *idtfc3 = platform_get_drvdata(pdev);
|
||||
|
||||
ptp_clock_unregister(idtfc3->ptp_clock);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
static struct platform_driver idtfc3_driver = {
|
||||
@ -1010,7 +1008,7 @@ static struct platform_driver idtfc3_driver = {
|
||||
.name = "rc38xxx-phc",
|
||||
},
|
||||
.probe = idtfc3_probe,
|
||||
.remove = idtfc3_remove,
|
||||
.remove_new = idtfc3_remove,
|
||||
};
|
||||
|
||||
module_platform_driver(idtfc3_driver);
|
||||
|
Loading…
Reference in New Issue
Block a user