kevin/linux
1
Fork 0
Code

genirq/msi: Fix off-by-one error in msi_domain_alloc()

Browse Source 
The error path in msi_domain_alloc(), frees the already allocated MSI
interrupts in a loop, but the loop condition terminates when the index
reaches zero, which fails to free the first allocated MSI interrupt at
index zero.

Check for >= 0 so that msi[0] is freed as well.

Fixes: f3cf8bb0d6 ("genirq: Add generic msi irq domain support")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20241026063639.10711-1-ruanjinjie@huawei.com
This commit is contained in:
Jinjie Ruan 2024-10-26 14:36:39 +08:00 committed by Thomas Gleixner
parent 42f7652d3e
commit 5f994f5341
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kernel/irq/msi.c
View File

@ -718,7 +718,7 @@ static int msi_domain_alloc(struct irq_domain *domain, unsigned int virq,
ret = ops->msi_init(domain, info, virq + i, hwirq + i, arg); ret = ops->msi_init(domain, info, virq + i, hwirq + i, arg);
if (ret < 0) { if (ret < 0) {
if (ops->msi_free) { if (ops->msi_free) {
for (i--; i > 0; i--) for (i--; i >= 0; i--)
ops->msi_free(domain, info, virq + i); ops->msi_free(domain, info, virq + i);
} }
irq_domain_free_irqs_top(domain, virq, nr_irqs); irq_domain_free_irqs_top(domain, virq, nr_irqs);