kevin/linux
1
Fork 0
Code

crypto: engine - Make crypto_engine_exit() return void

Browse Source 
All callers ignore the return value, so simplify by not providing one.

Note that crypto_engine_exit() is typically called in a device driver's
remove path (or the error path in probe), where errors cannot be handled
anyhow.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Uwe Kleine-König 2023-09-23 12:08:06 +02:00 committed by Herbert Xu
parent 0eb85cb3c8
commit 5ec12f1c7b
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
crypto/crypto_engine.c
View File

@ -552,20 +552,16 @@ EXPORT_SYMBOL_GPL(crypto_engine_alloc_init);
/** /**
* crypto_engine_exit - free the resources of hardware engine when exit * crypto_engine_exit - free the resources of hardware engine when exit
* @engine: the hardware engine need to be freed * @engine: the hardware engine need to be freed
*
* Return 0 for success.
*/ */
int crypto_engine_exit(struct crypto_engine *engine) void crypto_engine_exit(struct crypto_engine *engine)
{ {
int ret; int ret;
ret = crypto_engine_stop(engine); ret = crypto_engine_stop(engine);
if (ret) if (ret)
return ret; return;
kthread_destroy_worker(engine->kworker); kthread_destroy_worker(engine->kworker);
return 0;
} }
EXPORT_SYMBOL_GPL(crypto_engine_exit); EXPORT_SYMBOL_GPL(crypto_engine_exit);

2
include/crypto/engine.h
View File

@ -78,7 +78,7 @@ struct crypto_engine *crypto_engine_alloc_init_and_set(struct device *dev,
bool retry_support, bool retry_support,
int (*cbk_do_batch)(struct crypto_engine *engine), int (*cbk_do_batch)(struct crypto_engine *engine),
bool rt, int qlen); bool rt, int qlen);
int crypto_engine_exit(struct crypto_engine *engine); void crypto_engine_exit(struct crypto_engine *engine);
int crypto_engine_register_aead(struct aead_engine_alg *alg); int crypto_engine_register_aead(struct aead_engine_alg *alg);
void crypto_engine_unregister_aead(struct aead_engine_alg *alg); void crypto_engine_unregister_aead(struct aead_engine_alg *alg);