kevin/linux
1
Fork 0
Code

dmaengine: ti: omap-dma: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20230919133207.1400430-53-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-09-19 15:32:00 +02:00 committed by Vinod Koul
parent 68bcaf5c4e
commit 5ea68dc1ce
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/dma/ti/omap-dma.c
View File

@ -1844,7 +1844,7 @@ static int omap_dma_probe(struct platform_device *pdev)
return rc; return rc;
} }
static int omap_dma_remove(struct platform_device *pdev) static void omap_dma_remove(struct platform_device *pdev)
{ {
struct omap_dmadev *od = platform_get_drvdata(pdev); struct omap_dmadev *od = platform_get_drvdata(pdev);
int irq; int irq;
@ -1869,8 +1869,6 @@ static int omap_dma_remove(struct platform_device *pdev)
dma_pool_destroy(od->desc_pool); dma_pool_destroy(od->desc_pool);
omap_dma_free(od); omap_dma_free(od);
return 0;
} }
static const struct omap_dma_config omap2420_data = { static const struct omap_dma_config omap2420_data = {
@ -1918,7 +1916,7 @@ MODULE_DEVICE_TABLE(of, omap_dma_match);
static struct platform_driver omap_dma_driver = { static struct platform_driver omap_dma_driver = {
.probe = omap_dma_probe, .probe = omap_dma_probe,
.remove = omap_dma_remove, .remove_new = omap_dma_remove,
.driver = { .driver = {
.name = "omap-dma-engine", .name = "omap-dma-engine",
.of_match_table = omap_dma_match, .of_match_table = omap_dma_match,