kevin/linux
1
Fork 0
Code

i2c: iop3xx: reword according to newest specification

Browse Source 
Change the wording of this driver wrt. the newest I2C v7 and SMBus 3.2
specifications and replace "master/slave" with more appropriate terms.
Remove a useless comment while here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
This commit is contained in:
Wolfram Sang 2024-07-06 13:20:22 +02:00 committed by Andi Shyti
parent 8946eb1048
commit 5e705f93fb
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/i2c/busses/i2c-iop3xx.c
View File

@ -22,7 +22,7 @@
* - Make it work with IXP46x chips * - Make it work with IXP46x chips
* - Cleanup function names, coding style, etc * - Cleanup function names, coding style, etc
* *
* - writing to slave address causes latchup on iop331. * - writing to local target address causes latchup on iop331.
* fix: driver refuses to address self. * fix: driver refuses to address self.
*/ */
@ -234,7 +234,7 @@ iop3xx_i2c_send_target_addr(struct i2c_algo_iop3xx_data *iop3xx_adap,
int status; int status;
int rc; int rc;
/* avoid writing to my slave address (hangs on 80331), /* avoid writing to local target address (hangs on 80331),
* forbidden in Intel developer manual * forbidden in Intel developer manual
*/ */
if (msg->addr == MYSAR) { if (msg->addr == MYSAR) {
@ -349,12 +349,9 @@ iop3xx_i2c_handle_msg(struct i2c_adapter *i2c_adap, struct i2c_msg *pmsg)
} }
} }
/*
* master_xfer() - main read/write entry
*/
static int static int
iop3xx_i2c_master_xfer(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs, iop3xx_i2c_xfer(struct i2c_adapter *i2c_adap, struct i2c_msg *msgs,
int num) int num)
{ {
struct i2c_algo_iop3xx_data *iop3xx_adap = i2c_adap->algo_data; struct i2c_algo_iop3xx_data *iop3xx_adap = i2c_adap->algo_data;
int im = 0; int im = 0;
@ -384,8 +381,8 @@ iop3xx_i2c_func(struct i2c_adapter *adap)
} }
static const struct i2c_algorithm iop3xx_i2c_algo = { static const struct i2c_algorithm iop3xx_i2c_algo = {
.master_xfer = iop3xx_i2c_master_xfer, .xfer = iop3xx_i2c_xfer,
.functionality = iop3xx_i2c_func, .functionality = iop3xx_i2c_func,
}; };
static void static void