kevin/linux
1
Fork 0
Code

net/netrom: prefer strscpy over strcpy

Browse Source 
The deprecated helper strcpy() performs no bounds checking on the
destination buffer. This could result in linear overflows beyond
the end of the buffer, leading to all kinds of misbehaviors.
The safe replacement is strscpy() [1].

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
Link: https://patch.msgid.link/20240828123224.3697672-4-lihongbo22@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Hongbo Li 2024-08-28 20:32:21 +08:00 committed by Jakub Kicinski
parent b19f69a958
commit 597be7bd17
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/netrom/nr_route.c
View File

@ -189,7 +189,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
} }
nr_node->callsign = *nr; nr_node->callsign = *nr;
strcpy(nr_node->mnemonic, mnemonic); strscpy(nr_node->mnemonic, mnemonic);
nr_node->which = 0; nr_node->which = 0;
nr_node->count = 1; nr_node->count = 1;
@ -214,7 +214,7 @@ static int __must_check nr_add_node(ax25_address *nr, const char *mnemonic,
nr_node_lock(nr_node); nr_node_lock(nr_node);
if (quality != 0) if (quality != 0)
strcpy(nr_node->mnemonic, mnemonic); strscpy(nr_node->mnemonic, mnemonic);
for (found = 0, i = 0; i < nr_node->count; i++) { for (found = 0, i = 0; i < nr_node->count; i++) {
if (nr_node->routes[i].neighbour == nr_neigh) { if (nr_node->routes[i].neighbour == nr_neigh) {