kevin/linux
1
Fork 0
Code

mm/memory_hotplug: prevent accessing by index=-1

Browse Source 
nid may be equal to NUMA_NO_NODE=-1.  Prevent accessing node_data array by
invalid index with check for nid.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Link: https://lkml.kernel.org/r/20240606080659.18525-1-abelova@astralinux.ru
Fixes: e83a437faa ("mm/memory_hotplug: introduce "auto-movable" online policy")
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
Acked-by: David Hildenbrand <david@redhat.com>
Acked-by: Oscar Salvador <osalvador@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Anastasia Belova 2024-06-06 11:06:59 +03:00 committed by Andrew Morton
parent f742829d32
commit 5958d35917
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
mm/memory_hotplug.c
View File

@ -846,7 +846,6 @@ static bool auto_movable_can_online_movable(int nid, struct memory_group *group,
unsigned long kernel_early_pages, movable_pages; unsigned long kernel_early_pages, movable_pages;
struct auto_movable_group_stats group_stats = {}; struct auto_movable_group_stats group_stats = {};
struct auto_movable_stats stats = {}; struct auto_movable_stats stats = {};
pg_data_t *pgdat = NODE_DATA(nid);
struct zone *zone; struct zone *zone;
int i; int i;
@ -857,6 +856,8 @@ static bool auto_movable_can_online_movable(int nid, struct memory_group *group,
auto_movable_stats_account_zone(&stats, zone); auto_movable_stats_account_zone(&stats, zone);
} else { } else {
for (i = 0; i < MAX_NR_ZONES; i++) { for (i = 0; i < MAX_NR_ZONES; i++) {
pg_data_t *pgdat = NODE_DATA(nid);
zone = pgdat->node_zones + i; zone = pgdat->node_zones + i;
if (populated_zone(zone)) if (populated_zone(zone))
auto_movable_stats_account_zone(&stats, zone); auto_movable_stats_account_zone(&stats, zone);