kevin/linux
1
Fork 0
Code

ntfs3: Change to non-blocking allocation in ntfs_d_hash

Browse Source 
d_hash is done while under "rcu-walk" and should not sleep.
__get_name() allocates using GFP_KERNEL, having the possibility
to sleep when under memory pressure. Change the allocation to
GFP_NOWAIT.

Reported-by: syzbot+7f71f79bbfb4427b00e1@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=7f71f79bbfb4427b00e1
Fixes: d392e85fd1 ("fs/ntfs3: Fix the format of the "nocase" mount option")
Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
This commit is contained in:
Diogo Jahchan Koike 2024-09-02 14:19:32 -03:00 committed by Konstantin Komarov
parent bdd6baf740
commit 589996bf8c
No known key found for this signature in database
GPG Key ID: A9B0331F832407B6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/ntfs3/namei.c
View File

@ -395,7 +395,7 @@ static int ntfs_d_hash(const struct dentry *dentry, struct qstr *name)
/* /*
* Try slow way with current upcase table * Try slow way with current upcase table
*/ */
uni = __getname(); uni = kmem_cache_alloc(names_cachep, GFP_NOWAIT);
if (!uni) if (!uni)
return -ENOMEM; return -ENOMEM;
@ -417,7 +417,7 @@ static int ntfs_d_hash(const struct dentry *dentry, struct qstr *name)
err = 0; err = 0;
out: out:
__putname(uni); kmem_cache_free(names_cachep, uni);
return err; return err;
} }