kevin/linux
1
Fork 0
Code

fs/open.c: Fix W=1 kernel doc warnings

Browse Source 
fs/open.c: In functions 'setattr_vfsuid' and 'setattr_vfsgid':
 warning: Function parameter or member 'attr' not described
 - Fix warning by removing kernel-doc for these as they are static
   inline functions and not required to be exposed via kernel-doc.

fs/open.c:
 warning: Excess function parameter 'opened' description in 'finish_open'
 warning: Excess function parameter 'cred' description in 'vfs_open'
 - Fix by removing the parameters from the kernel-doc as they are no
   longer required by the function.

Signed-off-by: Anuradha Weeraman <anuradha@debian.org>
Message-Id: <20230506182928.384105-1-anuradha@debian.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Anuradha Weeraman 2023-05-06 23:59:27 +05:30 committed by Christian Brauner
parent c642256b91
commit 55650b2fdd
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
fs/open.c
View File

@ -700,10 +700,7 @@ SYSCALL_DEFINE2(chmod, const char __user *, filename, umode_t, mode)
return do_fchmodat(AT_FDCWD, filename, mode); return do_fchmodat(AT_FDCWD, filename, mode);
} }
/** /*
* setattr_vfsuid - check and set ia_fsuid attribute
* @kuid: new inode owner
*
* Check whether @kuid is valid and if so generate and set vfsuid_t in * Check whether @kuid is valid and if so generate and set vfsuid_t in
* ia_vfsuid. * ia_vfsuid.
* *
@ -718,10 +715,7 @@ static inline bool setattr_vfsuid(struct iattr *attr, kuid_t kuid)
return true; return true;
} }
/** /*
* setattr_vfsgid - check and set ia_fsgid attribute
* @kgid: new inode owner
*
* Check whether @kgid is valid and if so generate and set vfsgid_t in * Check whether @kgid is valid and if so generate and set vfsgid_t in
* ia_vfsgid. * ia_vfsgid.
* *
@ -989,7 +983,6 @@ cleanup_file:
* @file: file pointer * @file: file pointer
* @dentry: pointer to dentry * @dentry: pointer to dentry
* @open: open callback * @open: open callback
* @opened: state of open
* *
* This can be used to finish opening a file passed to i_op->atomic_open(). * This can be used to finish opening a file passed to i_op->atomic_open().
* *
@ -1043,7 +1036,6 @@ EXPORT_SYMBOL(file_path);
* vfs_open - open the file at the given path * vfs_open - open the file at the given path
* @path: path to open * @path: path to open
* @file: newly allocated file with f_flag initialized * @file: newly allocated file with f_flag initialized
* @cred: credentials to use
*/ */
int vfs_open(const struct path *path, struct file *file) int vfs_open(const struct path *path, struct file *file)
{ {