kevin/linux
1
Fork 0
Code

usb: dwc3: xilinx: improve error handling for PM APIs

Browse Source 
Improve error handling for PM APIs in the dwc3_xlnx_probe function by
introducing devm_pm_runtime_enable and error label. Removed unnecessary
API pm_runtime_disable call in dwc3_xlnx_remove.

Signed-off-by: Piyush Mehta <piyush.mehta@amd.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Link: https://lore.kernel.org/r/1700590878-124335-1-git-send-email-radhey.shyam.pandey@amd.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Piyush Mehta 2023-11-21 23:51:18 +05:30 committed by Greg Kroah-Hartman
parent 5192020767
commit 53b5ff83d8
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/usb/dwc3/dwc3-xilinx.c
View File

@ -293,11 +293,15 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
goto err_clk_put; goto err_clk_put;
pm_runtime_set_active(dev); pm_runtime_set_active(dev);
pm_runtime_enable(dev); ret = devm_pm_runtime_enable(dev);
pm_suspend_ignore_children(dev, false); if (ret < 0)
pm_runtime_get_sync(dev); goto err_pm_set_suspended;
return 0; pm_suspend_ignore_children(dev, false);
return pm_runtime_resume_and_get(dev);
err_pm_set_suspended:
pm_runtime_set_suspended(dev);
err_clk_put: err_clk_put:
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks); clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
@ -315,7 +319,6 @@ static void dwc3_xlnx_remove(struct platform_device *pdev)
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks); clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
priv_data->num_clocks = 0; priv_data->num_clocks = 0;
pm_runtime_disable(dev);
pm_runtime_put_noidle(dev); pm_runtime_put_noidle(dev);
pm_runtime_set_suspended(dev); pm_runtime_set_suspended(dev);
} }