misc: bh1770glc: use 'time_left' variable with wait_event_interruptible_timeout()
There is a confusing pattern in the kernel to use a variable named 'timeout' to store the result of wait_event_interruptible_timeout() causing patterns like: timeout = wait_event_interruptible_timeout(...) if (!timeout) return -ETIMEDOUT; with all kinds of permutations. Use 'time_left' as a variable to make the code self explaining. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Link: https://lore.kernel.org/r/20240604212240.4529-3-wsa+renesas@sang-engineering.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
parent
71f592d204
commit
531a185d54
@ -680,15 +680,15 @@ static ssize_t bh1770_lux_result_show(struct device *dev,
|
||||
{
|
||||
struct bh1770_chip *chip = dev_get_drvdata(dev);
|
||||
ssize_t ret;
|
||||
long timeout;
|
||||
long time_left;
|
||||
|
||||
if (pm_runtime_suspended(dev))
|
||||
return -EIO; /* Chip is not enabled at all */
|
||||
|
||||
timeout = wait_event_interruptible_timeout(chip->wait,
|
||||
!chip->lux_wait_result,
|
||||
msecs_to_jiffies(BH1770_TIMEOUT));
|
||||
if (!timeout)
|
||||
time_left = wait_event_interruptible_timeout(chip->wait,
|
||||
!chip->lux_wait_result,
|
||||
msecs_to_jiffies(BH1770_TIMEOUT));
|
||||
if (!time_left)
|
||||
return -EIO;
|
||||
|
||||
mutex_lock(&chip->mutex);
|
||||
|
Loading…
Reference in New Issue
Block a user