kevin/linux
1
Fork 0
Code

blk-mq: Remove the hctx 'run' debugfs attribute

Browse Source 
Nobody uses the debugfs hctx 'run' attribute. Hence remove this
attribute and also the code that updates the corresponding member
variable.

Suggested-by: Jens Axboe <axboe@kernel.dk>
Cc: Gabriel Ryan <gabe@cs.columbia.edu>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20240117203609.4122520-1-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Bart Van Assche 2024-01-17 12:36:09 -08:00 committed by Jens Axboe
parent 78fbb92af2
commit 49e60333d7
3 changed files with 0 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
block/blk-mq-debugfs.c
View File

@ -479,23 +479,6 @@ out:
return res; return res;
} }
static int hctx_run_show(void *data, struct seq_file *m)
{
struct blk_mq_hw_ctx *hctx = data;
seq_printf(m, "%lu\n", hctx->run);
return 0;
}
static ssize_t hctx_run_write(void *data, const char __user *buf, size_t count,
loff_t *ppos)
{
struct blk_mq_hw_ctx *hctx = data;
hctx->run = 0;
return count;
}
static int hctx_active_show(void *data, struct seq_file *m) static int hctx_active_show(void *data, struct seq_file *m)
{ {
struct blk_mq_hw_ctx *hctx = data; struct blk_mq_hw_ctx *hctx = data;
@ -624,7 +607,6 @@ static const struct blk_mq_debugfs_attr blk_mq_debugfs_hctx_attrs[] = {
{"tags_bitmap", 0400, hctx_tags_bitmap_show}, {"tags_bitmap", 0400, hctx_tags_bitmap_show},
{"sched_tags", 0400, hctx_sched_tags_show}, {"sched_tags", 0400, hctx_sched_tags_show},
{"sched_tags_bitmap", 0400, hctx_sched_tags_bitmap_show}, {"sched_tags_bitmap", 0400, hctx_sched_tags_bitmap_show},
{"run", 0600, hctx_run_show, hctx_run_write},
{"active", 0400, hctx_active_show}, {"active", 0400, hctx_active_show},
{"dispatch_busy", 0400, hctx_dispatch_busy_show}, {"dispatch_busy", 0400, hctx_dispatch_busy_show},
{"type", 0400, hctx_type_show}, {"type", 0400, hctx_type_show},

2
block/blk-mq-sched.c
View File

@ -324,8 +324,6 @@ void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)
if (unlikely(blk_mq_hctx_stopped(hctx) || blk_queue_quiesced(q))) if (unlikely(blk_mq_hctx_stopped(hctx) || blk_queue_quiesced(q)))
return; return;
hctx->run++;
/* /*
* A return of -EAGAIN is an indication that hctx->dispatch is not * A return of -EAGAIN is an indication that hctx->dispatch is not
* empty and we must run again in order to avoid starving flushes. * empty and we must run again in order to avoid starving flushes.

3
include/linux/blk-mq.h
View File

@ -391,9 +391,6 @@ struct blk_mq_hw_ctx {
*/ */
struct blk_mq_tags *sched_tags; struct blk_mq_tags *sched_tags;
/** @run: Number of dispatched requests. */
unsigned long run;
/** @numa_node: NUMA node the storage adapter has been connected to. */ /** @numa_node: NUMA node the storage adapter has been connected to. */
unsigned int numa_node; unsigned int numa_node;
/** @queue_num: Index of this hardware queue. */ /** @queue_num: Index of this hardware queue. */