kevin/linux
1
Fork 0
Code

debugfs: Convert to new uid/gid option parsing helpers

Browse Source 
Convert to new uid/gid option parsing helpers

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Link: https://lore.kernel.org/r/b2f44ee0-3cee-49eb-a416-f26a9306eb56@redhat.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Eric Sandeen 2024-06-27 19:29:46 -05:00 committed by Christian Brauner
parent 748cddf13d
commit 49abee5991
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
fs/debugfs/inode.c
View File

@ -92,9 +92,9 @@ enum {
}; };
static const struct fs_parameter_spec debugfs_param_specs[] = { static const struct fs_parameter_spec debugfs_param_specs[] = {
fsparam_u32 ("gid", Opt_gid), fsparam_gid ("gid", Opt_gid),
fsparam_u32oct ("mode", Opt_mode), fsparam_u32oct ("mode", Opt_mode),
fsparam_u32 ("uid", Opt_uid), fsparam_uid ("uid", Opt_uid),
{} {}
}; };
@ -102,8 +102,6 @@ static int debugfs_parse_param(struct fs_context *fc, struct fs_parameter *param
{ {
struct debugfs_fs_info *opts = fc->s_fs_info; struct debugfs_fs_info *opts = fc->s_fs_info;
struct fs_parse_result result; struct fs_parse_result result;
kuid_t uid;
kgid_t gid;
int opt; int opt;
opt = fs_parse(fc, debugfs_param_specs, param, &result); opt = fs_parse(fc, debugfs_param_specs, param, &result);
@ -112,16 +110,10 @@ static int debugfs_parse_param(struct fs_context *fc, struct fs_parameter *param
switch (opt) { switch (opt) {
case Opt_uid: case Opt_uid:
uid = make_kuid(current_user_ns(), result.uint_32); opts->uid = result.uid;
if (!uid_valid(uid))
return invalf(fc, "Unknown uid");
opts->uid = uid;
break; break;
case Opt_gid: case Opt_gid:
gid = make_kgid(current_user_ns(), result.uint_32); opts->gid = result.gid;
if (!gid_valid(gid))
return invalf(fc, "Unknown gid");
opts->gid = gid;
break; break;
case Opt_mode: case Opt_mode:
opts->mode = result.uint_32 & S_IALLUGO; opts->mode = result.uint_32 & S_IALLUGO;