kevin/linux
1
Fork 0
Code

kconfig: massage the loop in conf_read_simple()

Browse Source 
Make the while-loop code a little more readable.

The gain is that "CONFIG_FOO" without '=' is warned as unexpected data.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
This commit is contained in:
Masahiro Yamada 2023-11-18 16:59:12 +09:00
parent 4aced3ec84
commit 48ab6c9c92
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
scripts/kconfig/confdata.c
View File

@ -443,6 +443,10 @@ load:
while (getline_stripped(&line, &line_asize, in) != -1) { while (getline_stripped(&line, &line_asize, in) != -1) {
conf_lineno++; conf_lineno++;
if (!line[0]) /* blank line */
continue;
if (line[0] == '#') { if (line[0] == '#') {
if (line[1] != ' ') if (line[1] != ' ')
continue; continue;
@ -458,17 +462,20 @@ load:
continue; continue;
val = "n"; val = "n";
} else if (memcmp(line, CONFIG_, strlen(CONFIG_)) == 0) { } else {
if (memcmp(line, CONFIG_, strlen(CONFIG_))) {
conf_warning("unexpected data: %s", line);
continue;
}
sym_name = line + strlen(CONFIG_); sym_name = line + strlen(CONFIG_);
p = strchr(sym_name, '='); p = strchr(sym_name, '=');
if (!p) if (!p) {
conf_warning("unexpected data: %s", line);
continue; continue;
}
*p = 0; *p = 0;
val = p + 1; val = p + 1;
} else {
if (line[0] != '\0')
conf_warning("unexpected data: %s", line);
continue;
} }
sym = sym_find(sym_name); sym = sym_find(sym_name);