kevin/linux
1
Fork 0
Code

ata: pata_falcon: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-11-05 16:00:38 +01:00 committed by Damien Le Moal
parent 0b2771dd52
commit 47d4708dfa
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/ata/pata_falcon.c
View File

@ -216,18 +216,16 @@ static int pata_falcon_init_one(struct platform_device *pdev)
IRQF_SHARED, &pata_falcon_sht); IRQF_SHARED, &pata_falcon_sht);
} }
static int pata_falcon_remove_one(struct platform_device *pdev) static void pata_falcon_remove_one(struct platform_device *pdev)
{ {
struct ata_host *host = platform_get_drvdata(pdev); struct ata_host *host = platform_get_drvdata(pdev);
ata_host_detach(host); ata_host_detach(host);
return 0;
} }
static struct platform_driver pata_falcon_driver = { static struct platform_driver pata_falcon_driver = {
.probe = pata_falcon_init_one, .probe = pata_falcon_init_one,
.remove = pata_falcon_remove_one, .remove_new = pata_falcon_remove_one,
.driver = { .driver = {
.name = "atari-falcon-ide", .name = "atari-falcon-ide",
}, },