kevin/linux
1
Fork 0
Code

powerpc/pseries/vas: Use usleep_range() to support HCALL delay

Browse Source 
VAS allocate, modify and deallocate HCALLs returns
H_LONG_BUSY_ORDER_1_MSEC or H_LONG_BUSY_ORDER_10_MSEC for busy
delay and expects OS to reissue HCALL after that delay. But using
msleep() will often sleep at least 20 msecs even though the
hypervisor suggests OS reissue these HCALLs after 1 or 10msecs.

The open and close VAS window functions hold mutex and then issue
these HCALLs. So these operations can take longer than the
necessary when multiple threads issue open or close window APIs
simultaneously, especially might affect the performance in the
case of repeat open/close APIs for each compression request.

Multiple tasks can open / close VAS windows at the same time
which depends on the available VAS credits. For example, 240
cores system provides 4800 VAS credits. It means 4800 tasks can
execute open VAS windows HCALLs with the mutex. Since each
msleep() will often sleep more than 20 msecs, some tasks are
waiting more than 120 secs to acquire mutex. It can cause hung
traces for these tasks in dmesg due to mutex contention around
open/close HCALLs.

Instead of msleep(), use usleep_range() to ensure sleep with
the expected value before issuing HCALL again. So since each
task sleep 10 msecs maximum, this patch allow more tasks can
issue open/close VAS calls without any hung traces in the
dmesg.

Signed-off-by: Haren Myneni <haren@linux.ibm.com>
Suggested-by: Nathan Lynch <nathanl@linux.ibm.com>
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240116055910.421605-1-haren@linux.ibm.com
This commit is contained in:
Haren Myneni 2024-01-15 21:59:10 -08:00 committed by Michael Ellerman
parent 11981816e3
commit 43ac9f5cd4
1 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
arch/powerpc/platforms/pseries/vas.c
View File

@ -38,7 +38,27 @@ static long hcall_return_busy_check(long rc)
{
/* Check if we are stalled for some time */
if (H_IS_LONG_BUSY(rc)) {
msleep(get_longbusy_msecs(rc));
unsigned int ms;
/*
* Allocate, Modify and Deallocate HCALLs returns
* H_LONG_BUSY_ORDER_1_MSEC or H_LONG_BUSY_ORDER_10_MSEC
* for the long delay. So the sleep time should always
* be either 1 or 10msecs, but in case if the HCALL
* returns the long delay > 10 msecs, clamp the sleep
* time to 10msecs.
*/
ms = clamp(get_longbusy_msecs(rc), 1, 10);
/*
* msleep() will often sleep at least 20 msecs even
* though the hypervisor suggests that the OS reissue
* HCALLs after 1 or 10msecs. Also the delay hint from
* the HCALL is just a suggestion. So OK to pause for
* less time than the hinted delay. Use usleep_range()
* to ensure we don't sleep much longer than actually
* needed.
*/
usleep_range(ms * (USEC_PER_MSEC / 10), ms * USEC_PER_MSEC);
rc = H_BUSY;
} else if (rc == H_BUSY) {
cond_resched();