kevin/linux
1
Fork 0
Code

fuse: set FR_PENDING atomically in fuse_resend()

Browse Source 
When fuse_resend() moves the requests from processing lists to pending
list, it uses __set_bit() to set FR_PENDING bit in req->flags.

Using __set_bit() is not safe, because other functions may update
req->flags concurrently (e.g., request_wait_answer() may call
set_bit(FR_INTERRUPTED, &flags)).

Fix it by using set_bit() instead.

Fixes: 760eac73f9 ("fuse: Introduce a new notification type for resend pending requests")
Signed-off-by: Hou Tao <houtao1@huawei.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
This commit is contained in:
Hou Tao 2024-05-09 20:21:53 +08:00 committed by Miklos Szeredi
parent 9fe2a036a2
commit 42815f8ac5
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/fuse/dev.c
View File

@ -1813,7 +1813,7 @@ static void fuse_resend(struct fuse_conn *fc)
spin_unlock(&fc->lock); spin_unlock(&fc->lock);
list_for_each_entry_safe(req, next, &to_queue, list) { list_for_each_entry_safe(req, next, &to_queue, list) {
__set_bit(FR_PENDING, &req->flags); set_bit(FR_PENDING, &req->flags);
/* mark the request as resend request */ /* mark the request as resend request */
req->in.h.unique |= FUSE_UNIQUE_RESEND; req->in.h.unique |= FUSE_UNIQUE_RESEND;
} }