kevin/linux
1
Fork 0
Code

perf vdso: Missed put on 32-bit dsos

Browse Source 
If the dso type doesn't match then NULL is returned but the dso should
be put first.

Fixes: f649ed80f3 ("perf dsos: Tidy reference counting and locking")
Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20240912182757.762369-1-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
Ian Rogers 2024-09-12 11:27:57 -07:00 committed by Arnaldo Carvalho de Melo
parent 52c996d3f4
commit 424aafb61a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/perf/util/vdso.c
View File

@ -308,8 +308,10 @@ static struct dso *machine__find_vdso(struct machine *machine,
if (!dso) { if (!dso) {
dso = dsos__find(&machine->dsos, DSO__NAME_VDSO, dso = dsos__find(&machine->dsos, DSO__NAME_VDSO,
true); true);
if (dso && dso_type != dso__type(dso, machine)) if (dso && dso_type != dso__type(dso, machine)) {
dso__put(dso);
dso = NULL; dso = NULL;
}
} }
break; break;
case DSO__TYPE_X32BIT: case DSO__TYPE_X32BIT: