kevin/linux
1
Fork 0
Code

mfd: omap-usb-host: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231123165627.492259-11-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-11-23 17:56:38 +01:00 committed by Lee Jones
parent 795cf0ac2a
commit 418d1e74f8
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mfd/omap-usb-host.c
View File

@ -816,13 +816,12 @@ static int usbhs_omap_remove_child(struct device *dev, void *data)
* *
* Reverses the effect of usbhs_omap_probe(). * Reverses the effect of usbhs_omap_probe().
*/ */
static int usbhs_omap_remove(struct platform_device *pdev) static void usbhs_omap_remove(struct platform_device *pdev)
{ {
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
/* remove children */ /* remove children */
device_for_each_child(&pdev->dev, NULL, usbhs_omap_remove_child); device_for_each_child(&pdev->dev, NULL, usbhs_omap_remove_child);
return 0;
} }
static const struct dev_pm_ops usbhsomap_dev_pm_ops = { static const struct dev_pm_ops usbhsomap_dev_pm_ops = {
@ -845,7 +844,7 @@ static struct platform_driver usbhs_omap_driver = {
.of_match_table = usbhs_omap_dt_ids, .of_match_table = usbhs_omap_dt_ids,
}, },
.probe = usbhs_omap_probe, .probe = usbhs_omap_probe,
.remove = usbhs_omap_remove, .remove_new = usbhs_omap_remove,
}; };
MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>"); MODULE_AUTHOR("Keshava Munegowda <keshava_mgowda@ti.com>");