kevin/linux
1
Fork 0
Code

fpga: socfpga: Rename 'timeout' variable as 'time_left'

Browse Source 
There is a confusing pattern in the kernel to use a variable named
'timeout' to store the result of
wait_for_completion_interruptible_timeout() causing patterns like:

        timeout = wait_for_completion_interruptible_timeout(...)
        if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the
code self explaining.

Fix to the proper variable type 'long' while here.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Xu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/20240729104319.2658-1-wsa+renesas@sang-engineering.com
Signed-off-by: Xu Yilun <yilun.xu@linux.intel.com>
This commit is contained in:
Wolfram Sang 2024-07-29 12:42:22 +02:00 committed by Xu Yilun
parent d783ed2f5f
commit 4168ced7e0
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/fpga/socfpga.c
View File

@ -301,16 +301,17 @@ static irqreturn_t socfpga_fpga_isr(int irq, void *dev_id)
static int socfpga_fpga_wait_for_config_done(struct socfpga_fpga_priv *priv) static int socfpga_fpga_wait_for_config_done(struct socfpga_fpga_priv *priv)
{ {
int timeout, ret = 0; int ret = 0;
long time_left;
socfpga_fpga_disable_irqs(priv); socfpga_fpga_disable_irqs(priv);
init_completion(&priv->status_complete); init_completion(&priv->status_complete);
socfpga_fpga_enable_irqs(priv, SOCFPGA_FPGMGR_MON_CONF_DONE); socfpga_fpga_enable_irqs(priv, SOCFPGA_FPGMGR_MON_CONF_DONE);
timeout = wait_for_completion_interruptible_timeout( time_left = wait_for_completion_interruptible_timeout(
&priv->status_complete, &priv->status_complete,
msecs_to_jiffies(10)); msecs_to_jiffies(10));
if (timeout == 0) if (time_left == 0)
ret = -ETIMEDOUT; ret = -ETIMEDOUT;
socfpga_fpga_disable_irqs(priv); socfpga_fpga_disable_irqs(priv);