kevin/linux
1
Fork 0
Code

block: limit the Write Zeroes to manually writing zeroes fallback

Browse Source 
Only fall back from hardware Write Zeroes failures when
blkdev_issue_write_zeroes returns -EOPNOTSUPP;

Note that blkdev_issue_write_zeroes turns any failure into -EOPNOTSUPP
when the write zeroes queue limit has been cleared to 0, so this still
catches all I/O errors where the driver detected missing support
for the hardware acceleration.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Link: https://lore.kernel.org/r/20240701165219.1571322-10-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Christoph Hellwig 2024-07-01 18:51:19 +02:00 committed by Jens Axboe
parent 99800ced26
commit 39722a2f2b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
block/blk-lib.c
View File

@ -287,7 +287,7 @@ int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
if (bdev_write_zeroes_sectors(bdev)) { if (bdev_write_zeroes_sectors(bdev)) {
ret = blkdev_issue_write_zeroes(bdev, sector, nr_sects, ret = blkdev_issue_write_zeroes(bdev, sector, nr_sects,
gfp_mask, flags); gfp_mask, flags);
if (!ret) if (ret != -EOPNOTSUPP)
return ret; return ret;
} }