kevin/linux
1
Fork 0
Code

scsi: sni_53c710: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

In the error path emit an error message replacing the (less useful)
message by the core. Apart from the improved error message there is no
change in behaviour.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/2f4b7366ca00a107a9595514795e909e632980da.1701619134.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
This commit is contained in:
Uwe Kleine-König 2023-12-03 17:05:56 +01:00 committed by Martin K. Petersen
parent 358987af1b
commit 357a7fd243
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/scsi/sni_53c710.c
View File

@ -104,7 +104,7 @@ static int snirm710_probe(struct platform_device *dev)
return -ENODEV; return -ENODEV;
} }
static int snirm710_driver_remove(struct platform_device *dev) static void snirm710_driver_remove(struct platform_device *dev)
{ {
struct Scsi_Host *host = dev_get_drvdata(&dev->dev); struct Scsi_Host *host = dev_get_drvdata(&dev->dev);
struct NCR_700_Host_Parameters *hostdata = struct NCR_700_Host_Parameters *hostdata =
@ -115,13 +115,11 @@ static int snirm710_driver_remove(struct platform_device *dev)
free_irq(host->irq, host); free_irq(host->irq, host);
iounmap(hostdata->base); iounmap(hostdata->base);
kfree(hostdata); kfree(hostdata);
return 0;
} }
static struct platform_driver snirm710_driver = { static struct platform_driver snirm710_driver = {
.probe = snirm710_probe, .probe = snirm710_probe,
.remove = snirm710_driver_remove, .remove_new = snirm710_driver_remove,
.driver = { .driver = {
.name = "snirm_53c710", .name = "snirm_53c710",
}, },