kevin/linux
1
Fork 0
Code

mfd: omap-usb-tll: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231123165627.492259-12-u.kleine-koenig@pengutronix.de
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Uwe Kleine-König 2023-11-23 17:56:39 +01:00 committed by Lee Jones
parent 418d1e74f8
commit 32c9cd0abc
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mfd/omap-usb-tll.c
View File

@ -270,7 +270,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
* *
* Reverses the effect of usbtll_omap_probe(). * Reverses the effect of usbtll_omap_probe().
*/ */
static int usbtll_omap_remove(struct platform_device *pdev) static void usbtll_omap_remove(struct platform_device *pdev)
{ {
struct usbtll_omap *tll = platform_get_drvdata(pdev); struct usbtll_omap *tll = platform_get_drvdata(pdev);
int i; int i;
@ -287,7 +287,6 @@ static int usbtll_omap_remove(struct platform_device *pdev)
} }
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
return 0;
} }
static const struct of_device_id usbtll_omap_dt_ids[] = { static const struct of_device_id usbtll_omap_dt_ids[] = {
@ -303,7 +302,7 @@ static struct platform_driver usbtll_omap_driver = {
.of_match_table = usbtll_omap_dt_ids, .of_match_table = usbtll_omap_dt_ids,
}, },
.probe = usbtll_omap_probe, .probe = usbtll_omap_probe,
.remove = usbtll_omap_remove, .remove_new = usbtll_omap_remove,
}; };
int omap_tll_init(struct usbhs_omap_platform_data *pdata) int omap_tll_init(struct usbhs_omap_platform_data *pdata)