kevin/linux
1
Fork 0
Code

memory: pl353-smc: simplify with scoped for each OF child loop

Browse Source 
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Suggested-by: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/r/20240825135001.48963-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
This commit is contained in:
Krzysztof Kozlowski 2024-08-25 15:50:01 +02:00
parent 331b8a9631
commit 32960b4f25
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/memory/pl353-smc.c
View File

@ -74,7 +74,6 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
struct device_node *of_node = adev->dev.of_node; struct device_node *of_node = adev->dev.of_node;
const struct of_device_id *match = NULL; const struct of_device_id *match = NULL;
struct pl353_smc_data *pl353_smc; struct pl353_smc_data *pl353_smc;
struct device_node *child;
pl353_smc = devm_kzalloc(&adev->dev, sizeof(*pl353_smc), GFP_KERNEL); pl353_smc = devm_kzalloc(&adev->dev, sizeof(*pl353_smc), GFP_KERNEL);
if (!pl353_smc) if (!pl353_smc)
@ -93,12 +92,13 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
amba_set_drvdata(adev, pl353_smc); amba_set_drvdata(adev, pl353_smc);
/* Find compatible children. Only a single child is supported */ /* Find compatible children. Only a single child is supported */
for_each_available_child_of_node(of_node, child) { for_each_available_child_of_node_scoped(of_node, child) {
match = of_match_node(pl353_smc_supported_children, child); match = of_match_node(pl353_smc_supported_children, child);
if (!match) { if (!match) {
dev_warn(&adev->dev, "unsupported child node\n"); dev_warn(&adev->dev, "unsupported child node\n");
continue; continue;
} }
of_platform_device_create(child, NULL, &adev->dev);
break; break;
} }
if (!match) { if (!match) {
@ -106,9 +106,6 @@ static int pl353_smc_probe(struct amba_device *adev, const struct amba_id *id)
return -ENODEV; return -ENODEV;
} }
of_platform_device_create(child, NULL, &adev->dev);
of_node_put(child);
return 0; return 0;
} }