kevin/linux
1
Fork 0
Code

misc: xilinx_sdfec: Convert to platform remove callback returning void

Browse Source 
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/705b89c3cd7c0a42ce3f482f202204f5e3377aa2.1708508896.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Uwe Kleine-König 2024-02-21 10:53:54 +01:00 committed by Greg Kroah-Hartman
parent be7e1a4c47
commit 2743e96f88
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/misc/xilinx_sdfec.c
View File

@ -1420,7 +1420,7 @@ err_xsdfec_dev:
return err; return err;
} }
static int xsdfec_remove(struct platform_device *pdev) static void xsdfec_remove(struct platform_device *pdev)
{ {
struct xsdfec_dev *xsdfec; struct xsdfec_dev *xsdfec;
@ -1428,7 +1428,6 @@ static int xsdfec_remove(struct platform_device *pdev)
misc_deregister(&xsdfec->miscdev); misc_deregister(&xsdfec->miscdev);
ida_free(&dev_nrs, xsdfec->dev_id); ida_free(&dev_nrs, xsdfec->dev_id);
xsdfec_disable_all_clks(&xsdfec->clks); xsdfec_disable_all_clks(&xsdfec->clks);
return 0;
} }
static const struct of_device_id xsdfec_of_match[] = { static const struct of_device_id xsdfec_of_match[] = {
@ -1445,7 +1444,7 @@ static struct platform_driver xsdfec_driver = {
.of_match_table = xsdfec_of_match, .of_match_table = xsdfec_of_match,
}, },
.probe = xsdfec_probe, .probe = xsdfec_probe,
.remove = xsdfec_remove, .remove_new = xsdfec_remove,
}; };
module_platform_driver(xsdfec_driver); module_platform_driver(xsdfec_driver);